v1.17: geyser: allow custom name in config file (backport of #33550) #34669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Allow loading the plugin name from the json config file as opposed to use plugin.name which is called before config file is passed to it. Allowing different plugins using the same executable to use different names. (cherry picked from commit c82fc6c) # Conflicts: # geyser-plugin-manager/src/geyser_plugin_manager.rs
|
We can't backport this to beta at this point in the stabilization cycle... The master version of this has run on canaries but not on a whole cluster. Since beta will be promoted to stable soon, backporting this to beta will ship it to mainnet-beta very quickly with minimal time to test on testnet. |
|
branch with fix: https://github.com/fanatid/solana/tree/pr-33550 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #34669 +/- ##
=======================================
Coverage 81.6% 81.7%
=======================================
Files 805 805
Lines 218806 218825 +19
=======================================
+ Hits 178747 178801 +54
+ Misses 40059 40024 -35 |
lijunwangs
approved these changes
Jan 20, 2024
|
This change is very low risk -- only loading the plugin name from the config file if set, otherwise the logic should behaves as before. Okay to backport. |
willhickey
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #33550 done by Mergify.
Cherry-pick of c82fc6c has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com